Update SupaSocialsAuth to pass scopes and query params to signInWithOAuth #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Auth Allows for triggering consent prompts.
dshukertjr
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Thanks for this! Yes, it would be great if we could support scopes and queryParams for social auth!
Would you be able to update it so that we can pass different scopes and queryParams for each provider?
Maybe we could make scopes type Map<OAuthProvider, String>?, make queryParams type Map<OAuthProvider, Map<String, String>>? so that users can specify different parameters for different OAuth provider?
|
That makes sense, I'll try it out here in a couple of days and update. |
…s can be passed for each providers
dshukertjr
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix/Enhancement to SupaSocialsAuth.
What is the current behavior?
Without the
scopesand ability to includeprompt=consentin the provider OpenID/authorizerequest, users are never given the opportunity to grant permissions to an app beyond just the ability to sign in.What is the new behavior?
It is now possible to add scopes and query parameters to
SocialsAuth.This example triggers a consent prompt for all permissions the Azure app registration has requested.
https://learn.microsoft.com/en-us/entra/identity-platform/scopes-oidc#the-default-scope
Additional context
This is a requirement for apps using Azure Active Directory and the Microsoft Graph API unless we want to make an Azure AD admin manually grant permissions through the Azure console any time they change.